Re: [Mesa-dev] [PATCH] glsl: fix infinite loop caused by bug in loop unrolling pass

2018-03-26 Thread Ian Romanick
On 03/25/2018 04:31 PM, Timothy Arceri wrote: > Just checking for 2 jumps is not enough to be sure we can do a > complex loop unroll. We need to make sure we also have also found > 2 loop terminators. > > Without this we were attempting to unroll a loop where the second > jump was nesed inside mul

Re: [Mesa-dev] [PATCH] glsl: fix infinite loop caused by bug in loop unrolling pass

2018-03-26 Thread Gert Wollny
This fixes the bug for me, thanks, Tested-by: Gert Wollny Am Montag, den 26.03.2018, 10:31 +1100 schrieb Timothy Arceri: > Just checking for 2 jumps is not enough to be sure we can do a > complex loop unroll. We need to make sure we also have also found > 2 loop terminators. > > Without this we

[Mesa-dev] [PATCH] glsl: fix infinite loop caused by bug in loop unrolling pass

2018-03-25 Thread Timothy Arceri
Just checking for 2 jumps is not enough to be sure we can do a complex loop unroll. We need to make sure we also have also found 2 loop terminators. Without this we were attempting to unroll a loop where the second jump was nesed inside multiple ifs which loop analysis is unable to detect as a ter