Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Timothy Arceri
On Thu, 2015-05-28 at 07:07 +1000, Dave Airlie wrote: > On 28 May 2015 at 06:51, Timothy Arceri wrote: > > Matt Turner wrote > > > >> On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri > >> wrote: > >> > Cc: Kenneth Graunke > >> > --- > >> > > >> > It looks like this may never have actua

Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Dave Airlie
On 28 May 2015 at 06:51, Timothy Arceri wrote: > Matt Turner wrote > >> On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri >> wrote: >> > Cc: Kenneth Graunke >> > --- >> > >> > It looks like this may never have actually worked, at least there >> > is no way it could have for inteface bl

Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Timothy Arceri
Matt Turner wrote > On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri wrote: > > Cc: Kenneth Graunke > > --- > > > > It looks like this may never have actually worked, at least there > > is no way it could have for inteface block arrays :) > > > > No piglit regressions. > > > > src

Re: [Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Matt Turner
On Wed, May 27, 2015 at 3:53 AM, Timothy Arceri wrote: > Cc: Kenneth Graunke > --- > > It looks like this may never have actually worked, at least there > is no way it could have for inteface block arrays :) > > No piglit regressions. > > src/glsl/ast_to_hir.cpp | 22 ++ >

[Mesa-dev] [PATCH] glsl: fix binding validation for interface blocks

2015-05-27 Thread Timothy Arceri
Cc: Kenneth Graunke --- It looks like this may never have actually worked, at least there is no way it could have for inteface block arrays :) No piglit regressions. src/glsl/ast_to_hir.cpp | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/glsl/