Re: [Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-19 Thread Samuel Iglesias Gonsálvez
On 19/10/15 13:18, Samuel Iglesias Gonsálvez wrote: > Reviewed-by: Samuel Iglesias Gonsálvez > Just one thing I forgot to say, Can you be more verbose about what it fixes in the subject line? "glsl: fix regression when building interface field name for SSBOs" or something like that. Sam >

Re: [Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-19 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 18/10/15 00:19, Timothy Arceri wrote: > Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e > > We don't care about the swizzle when building the name so just skip over it. > --- > > New piglit test: http://patchwork.freedesktop.org/patc

Re: [Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-19 Thread Emil Velikov
On 18 October 2015 at 13:45, Timothy Arceri wrote: > On Sun, 2015-10-18 at 11:34 +0100, Emil Velikov wrote: >> Hi Timothy, >> >> On 17 October 2015 at 23:19, Timothy Arceri >> wrote: >> > Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e >> > >> > We don't care about the swizzle

Re: [Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-18 Thread Timothy Arceri
On Sun, 2015-10-18 at 11:34 +0100, Emil Velikov wrote: > Hi Timothy, > > On 17 October 2015 at 23:19, Timothy Arceri > wrote: > > Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e > > > > We don't care about the swizzle when building the name so just skip > > over it. > > --- >

Re: [Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-18 Thread Emil Velikov
Hi Timothy, On 17 October 2015 at 23:19, Timothy Arceri wrote: > Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e > > We don't care about the swizzle when building the name so just skip over it. > --- > > New piglit test: http://patchwork.freedesktop.org/patch/62111/ > > src/g

[Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-17 Thread Timothy Arceri
Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e We don't care about the swizzle when building the name so just skip over it. --- New piglit test: http://patchwork.freedesktop.org/patch/62111/ src/glsl/lower_ubo_reference.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --g