Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-06 Thread Chia-I Wu
On Sat, Aug 6, 2011 at 5:35 AM, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/05/2011 12:41 AM, Chia-I Wu wrote: >> On Fri, Aug 5, 2011 at 1:48 PM, Chad Versace wrote: >>> On 08/04/2011 06:18 PM, Chad Versace wrote: On 08/04/2011 01:29 PM, Eric Anholt wrote:

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/05/2011 12:41 AM, Chia-I Wu wrote: > On Fri, Aug 5, 2011 at 1:48 PM, Chad Versace wrote: >> On 08/04/2011 06:18 PM, Chad Versace wrote: >>> On 08/04/2011 01:29 PM, Eric Anholt wrote: On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: >>>

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Kenneth Graunke
On 08/04/2011 09:48 PM, Chad Versace wrote: > On 08/04/2011 06:18 PM, Chad Versace wrote: >> On 08/04/2011 01:29 PM, Eric Anholt wrote: >>> On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: From: Chia-I Wu Unlike C++, empty declarations such as float; shoul

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Chad Versace
On 08/05/2011 11:45 AM, Paul Berry wrote: > On 4 August 2011 18:18, Chad Versace wrote: >> On 08/04/2011 01:29 PM, Eric Anholt wrote: >>> On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: From: Chia-I Wu Unlike C++, empty declarations such as float; should

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Chad Versace
On 08/05/2011 12:41 AM, Chia-I Wu wrote: > On Fri, Aug 5, 2011 at 1:48 PM, Chad Versace wrote: >> Also, please update the commit message to say that `gcc --std=c99` allows >> empty >> declrations and include the appropriate quotation from the GLSL 1.20 spec's >> grammar. Without that extra info,

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Paul Berry
On 4 August 2011 18:18, Chad Versace wrote: > On 08/04/2011 01:29 PM, Eric Anholt wrote: >> On Thu,  4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: >>> From: Chia-I Wu >>> >>> Unlike C++, empty declarations such as >>> >>>   float; >>> >>> should be valid.  The spec is not explicit about this actua

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-05 Thread Chia-I Wu
On Fri, Aug 5, 2011 at 1:48 PM, Chad Versace wrote: > On 08/04/2011 06:18 PM, Chad Versace wrote: >> On 08/04/2011 01:29 PM, Eric Anholt wrote: >>> On Thu,  4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: From: Chia-I Wu Unlike C++, empty declarations such as   float; >

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-04 Thread Chad Versace
On 08/04/2011 06:18 PM, Chad Versace wrote: > On 08/04/2011 01:29 PM, Eric Anholt wrote: >> On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: >>> From: Chia-I Wu >>> >>> Unlike C++, empty declarations such as >>> >>> float; >>> >>> should be valid. The spec is not explicit about this actual

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-04 Thread Chad Versace
On 08/04/2011 01:29 PM, Eric Anholt wrote: > On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: >> From: Chia-I Wu >> >> Unlike C++, empty declarations such as >> >> float; >> >> should be valid. The spec is not explicit about this actually. >> >> Some apps that generate their shader sources

Re: [Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-04 Thread Eric Anholt
On Thu, 4 Aug 2011 12:59:35 +0900, Chia-I Wu wrote: > From: Chia-I Wu > > Unlike C++, empty declarations such as > > float; > > should be valid. The spec is not explicit about this actually. > > Some apps that generate their shader sources may rely on this. This was > noted when porting

[Mesa-dev] [PATCH] glsl: empty declarations should be valid

2011-08-03 Thread Chia-I Wu
From: Chia-I Wu Unlike C++, empty declarations such as float; should be valid. The spec is not explicit about this actually. Some apps that generate their shader sources may rely on this. This was noted when porting one of them to Linux from Windows. --- src/glsl/ast_to_hir.cpp | 10 +++