Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Tapani
On 01/20/2015 08:29 PM, Ian Romanick wrote: On 01/19/2015 10:55 PM, Tapani Pälli wrote: Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert Signed-off-by: Tapani Pälli --- src/glsl/ast_to_hir.cpp | 17 - 1 file changed, 16 insertions(+), 1 dele

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Ian Romanick
On 01/20/2015 10:42 AM, Chris Forbes wrote: > Ian, > > That's what the -2 variation added by that commit does. Of course. :) Not sure how I overlooked that. > - Chris > > On Wed, Jan 21, 2015 at 7:29 AM, Ian Romanick wrote: >> On 01/19/2015 10:55 PM, Tapani Pälli wrote: >>> Fixes currently fa

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Chris Forbes
Ian, That's what the -2 variation added by that commit does. - Chris On Wed, Jan 21, 2015 at 7:29 AM, Ian Romanick wrote: > On 01/19/2015 10:55 PM, Tapani Pälli wrote: >> Fixes currently failing Piglit case >>interface-blocks-name-reused-globally.vert >> >> Signed-off-by: Tapani Pälli >> -

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Ian Romanick
On 01/19/2015 10:55 PM, Tapani Pälli wrote: > Fixes currently failing Piglit case >interface-blocks-name-reused-globally.vert > > Signed-off-by: Tapani Pälli > --- > src/glsl/ast_to_hir.cpp | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/a

[Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-19 Thread Tapani Pälli
Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert Signed-off-by: Tapani Pälli --- src/glsl/ast_to_hir.cpp | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 811a955..13ddb00