Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-13 Thread Emil Velikov
On 10 October 2015 at 01:56, Rob Clark wrote: > On Fri, Oct 9, 2015 at 8:07 PM, Emil Velikov wrote: >> On 9 October 2015 at 23:27, Rob Clark wrote: >>> On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov >>> wrote: On 9 October 2015 at 21:31, Rob Clark wrote: > From: Rob Clark > >

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Rob Clark
On Fri, Oct 9, 2015 at 8:07 PM, Emil Velikov wrote: > On 9 October 2015 at 23:27, Rob Clark wrote: >> On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov >> wrote: >>> On 9 October 2015 at 21:31, Rob Clark wrote: From: Rob Clark Add missing enum to gl_system_value_name() and move VARY

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Emil Velikov
On 9 October 2015 at 23:27, Rob Clark wrote: > On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov wrote: >> On 9 October 2015 at 21:31, Rob Clark wrote: >>> From: Rob Clark >>> >>> Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / >>> FRAG_RESULT_MAX / etc into shader_enums.h as

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Rob Clark
On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov wrote: > On 9 October 2015 at 21:31, Rob Clark wrote: >> From: Rob Clark >> >> Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / >> FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. >> >> Reported-by: Emil Velikov >

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Emil Velikov
On 9 October 2015 at 21:31, Rob Clark wrote: > From: Rob Clark > > Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / > FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. > > Reported-by: Emil Velikov > Signed-off-by: Rob Clark > --- > Note: punted on the STATIC

[Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Rob Clark
From: Rob Clark Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. Reported-by: Emil Velikov Signed-off-by: Rob Clark --- Note: punted on the STATIC_ASSERT() thing for now.. kinda wanted some- think more like