Re: [Mesa-dev] [PATCH] glsl: correctly detect inactive UBO arrays

2015-09-23 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 23/09/15 05:23, Timothy Arceri wrote: > Previously the code was trying to get the packing type from the array not the > interface. > > Cc: Ian Romanick > Cc: Antia Puentes > --- > src/glsl/link_uniform_block_active_visitor.cpp | 6 ++ > src/glsl/o

Re: [Mesa-dev] [PATCH] glsl: correctly detect inactive UBO arrays

2015-09-22 Thread Timothy Arceri
On Wed, 2015-09-23 at 13:23 +1000, Timothy Arceri wrote: > Previously the code was trying to get the packing type from the array > not the > interface. > > Cc: Ian Romanick > Cc: Antia Puentes I meant to add that there is a piglit test here [1] and that this fixes the second bug mentioned in th

[Mesa-dev] [PATCH] glsl: correctly detect inactive UBO arrays

2015-09-22 Thread Timothy Arceri
Previously the code was trying to get the packing type from the array not the interface. Cc: Ian Romanick Cc: Antia Puentes --- src/glsl/link_uniform_block_active_visitor.cpp | 6 ++ src/glsl/opt_dead_code.cpp | 7 ++- 2 files changed, 4 insertions(+), 9 deletions(-)