Re: [Mesa-dev] [PATCH] glsl: avoid using gl context as a memory context

2012-12-15 Thread Dave Airlie
> > Hmm... I wonder if this is related to bug #58039. > > I think we should have a flag-day patch that changes all the places where > the memory context is called ctx to call it mem_ctx. That might make future > problems like this easier to notice in code review. > That glsl_parser_extras.cpp is

Re: [Mesa-dev] [PATCH] glsl: avoid using gl context as a memory context

2012-12-15 Thread Ian Romanick
On 12/14/2012 07:26 PM, Dave Airlie wrote: Not sure what was going on here, but running piglit with debug builds might be a good plan :-) Hmm... I wonder if this is related to bug #58039. I think we should have a flag-day patch that changes all the places where the memory context is called ct

Re: [Mesa-dev] [PATCH] glsl: avoid using gl context as a memory context

2012-12-14 Thread Kenneth Graunke
On 12/14/2012 07:26 PM, Dave Airlie wrote: Not sure what was going on here, but running piglit with debug builds might be a good plan :-) Signed-off-by: Dave Airlie --- src/glsl/linker.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH] glsl: avoid using gl context as a memory context

2012-12-14 Thread Dave Airlie
Not sure what was going on here, but running piglit with debug builds might be a good plan :-) Signed-off-by: Dave Airlie --- src/glsl/linker.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 83d0e87..be08156 100644 -