Re: [Mesa-dev] [PATCH] glsl: avoid calling base_alignment when samplers are involved

2015-03-24 Thread Ilia Mirkin
On Tue, Mar 24, 2015 at 1:55 PM, Ian Romanick wrote: > On 03/23/2015 05:00 AM, Ilia Mirkin wrote: >> diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp >> index 799c74b..59adc29 100644 >> --- a/src/glsl/link_uniforms.cpp >> +++ b/src/glsl/link_uniforms.cpp >> @@ -547,6 +547,8 @@

Re: [Mesa-dev] [PATCH] glsl: avoid calling base_alignment when samplers are involved

2015-03-24 Thread Ian Romanick
On 03/23/2015 05:00 AM, Ilia Mirkin wrote: > Earlier commit 53bf7c8fd2e changed the logic to always call > base_alignment on structs. 1ec715ce8b12 hacked the function to return 0 > for sampler fields, but didn't handle sampler arrays. Instead of > extending the hack, avoid calling base_alignment in

Re: [Mesa-dev] [PATCH] glsl: avoid calling base_alignment when samplers are involved

2015-03-24 Thread Tapani Pälli
Reviewed-by: Tapani Palli On 03/23/2015 02:00 PM, Ilia Mirkin wrote: Earlier commit 53bf7c8fd2e changed the logic to always call base_alignment on structs. 1ec715ce8b12 hacked the function to return 0 for sampler fields, but didn't handle sampler arrays. Instead of extending the hack, avoid cal

[Mesa-dev] [PATCH] glsl: avoid calling base_alignment when samplers are involved

2015-03-23 Thread Ilia Mirkin
Earlier commit 53bf7c8fd2e changed the logic to always call base_alignment on structs. 1ec715ce8b12 hacked the function to return 0 for sampler fields, but didn't handle sampler arrays. Instead of extending the hack, avoid calling base_alignment in the first place on non-UBO uniforms. Bugzilla: ht