Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Ian Romanick
On 06/30/2016 12:50 AM, Andres Gomez wrote: > On Thu, 2016-06-30 at 00:29 -0700, Ian Romanick wrote: >> On 06/29/2016 05:55 PM, Timothy Arceri wrote: > ... >>> >> >> So, I don't think there is a clear part of the spec to quote here, >> and >> I looked. :) While the spec doesn't come right out and

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Andres Gomez
On Thu, 2016-06-30 at 10:55 +1000, Timothy Arceri wrote: > On Mon, 2016-06-27 at 18:28 +0300, Andres Gomez wrote: > > The linker deals with atomic counters in terms of uniforms. This is > > OK > > but when we want to know the number of used atomic counters since a > > 2 > > elements atomic counters

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Andres Gomez
On Wed, 2016-06-29 at 18:37 -0700, Ian Romanick wrote: > On 06/27/2016 08:28 AM, Andres Gomez wrote: > > The linker deals with atomic counters in terms of uniforms. This is > > OK > > but when we want to know the number of used atomic counters since a > > 2 > > elements atomic counters array will u

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Andres Gomez
On Thu, 2016-06-30 at 00:29 -0700, Ian Romanick wrote: > On 06/29/2016 05:55 PM, Timothy Arceri wrote: ... > > > > So, I don't think there is a clear part of the spec to quote here, > and > I looked. :)  While the spec doesn't come right out and say it, I > think > we can infer that this behavior

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-30 Thread Ian Romanick
On 06/29/2016 05:55 PM, Timothy Arceri wrote: > On Mon, 2016-06-27 at 18:28 +0300, Andres Gomez wrote: >> The linker deals with atomic counters in terms of uniforms. This is >> OK >> but when we want to know the number of used atomic counters since a 2 >> elements atomic counters array will use 2 c

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-29 Thread Ian Romanick
On 06/27/2016 08:28 AM, Andres Gomez wrote: > The linker deals with atomic counters in terms of uniforms. This is OK > but when we want to know the number of used atomic counters since a 2 > elements atomic counters array will use 2 counters but only 1 uniform. > > Renamed the data structures used

Re: [Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-29 Thread Timothy Arceri
On Mon, 2016-06-27 at 18:28 +0300, Andres Gomez wrote: > The linker deals with atomic counters in terms of uniforms. This is > OK > but when we want to know the number of used atomic counters since a 2 > elements atomic counters array will use 2 counters but only 1 > uniform. You don't really ment

[Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

2016-06-27 Thread Andres Gomez
The linker deals with atomic counters in terms of uniforms. This is OK but when we want to know the number of used atomic counters since a 2 elements atomic counters array will use 2 counters but only 1 uniform. Renamed the data structures used in the linker for disambiguation. Fixes GL44-CTS.arr