Re: [Mesa-dev] [PATCH] glsl: allow precision qualifier on sampler arrays

2014-09-08 Thread Tapani Pälli
On 09/09/2014 09:10 AM, Tapani Pälli wrote: > Hi Frank; > > Kalyan sent me a similar fix mentioning that it is related to this test > case: > https://www.khronos.org/registry/webgl/sdk/tests/conformance/limits/gl-min-textures.html > > If your patch is related, please mention in the commit message.

Re: [Mesa-dev] [PATCH] glsl: allow precision qualifier on sampler arrays

2014-09-08 Thread Tapani Pälli
Hi Frank; Kalyan sent me a similar fix mentioning that it is related to this test case: https://www.khronos.org/registry/webgl/sdk/tests/conformance/limits/gl-min-textures.html If your patch is related, please mention in the commit message. It helps to track possible regression in the future. Wi

Re: [Mesa-dev] [PATCH] glsl: allow precision qualifier on sampler arrays

2014-08-25 Thread Anuj Phogat
On Fri, Aug 22, 2014 at 2:23 PM, Frank Henigman wrote: > If a precision qualifer is allowed on type T, it should be allowed > on an array of T. Refactor the check to ensure this is the case. > --- > I wanted to expand the comment to say why is_record() is in there, > but I don't understand why it

[Mesa-dev] [PATCH] glsl: allow precision qualifier on sampler arrays

2014-08-22 Thread Frank Henigman
If a precision qualifer is allowed on type T, it should be allowed on an array of T. Refactor the check to ensure this is the case. --- I wanted to expand the comment to say why is_record() is in there, but I don't understand why it is. I thought structs couldn't have precision qualifiers. src/