Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 6:23 PM, Erik Faye-Lund wrote: > On Thu, Jul 2, 2015 at 2:56 PM, Ilia Mirkin wrote: >> On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner wrote: >>> On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin wrote: Can this be done at dlopen/init time? For example what happens if you do >

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Erik Faye-Lund
On Thu, Jul 2, 2015 at 2:56 PM, Ilia Mirkin wrote: > On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner wrote: >> On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin wrote: >>> Can this be done at dlopen/init time? For example what happens if you do >>> >>> static int foo = _mesa_locale_init() >>> >>> IIRC thi

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner wrote: > On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin wrote: >> Can this be done at dlopen/init time? For example what happens if you do >> >> static int foo = _mesa_locale_init() >> >> IIRC things like that are possible in C++, not sure about C. > > gcc

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Matt Turner
On Thu, Jul 2, 2015 at 2:18 PM, Erik Faye-Lund wrote: > After c61bc6e ("util: port _mesa_strto[df] to C"), "make check" > fails due to a missing _mesa_locale_init. Fixup this oversight. > > Signed-off-by: Erik Faye-Lund > Tested-by: Vinson Lee Reviewed-by: Matt Turner I'll commit this soon. _

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Matt Turner
On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin wrote: > Can this be done at dlopen/init time? For example what happens if you do > > static int foo = _mesa_locale_init() > > IIRC things like that are possible in C++, not sure about C. gcc has __attribute__((constructor)). But I don't think we reall

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Ilia Mirkin
Can this be done at dlopen/init time? For example what happens if you do static int foo = _mesa_locale_init() IIRC things like that are possible in C++, not sure about C. On Thu, Jul 2, 2015 at 5:18 PM, Erik Faye-Lund wrote: > After c61bc6e ("util: port _mesa_strto[df] to C"), "make check" > fa

[Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Erik Faye-Lund
After c61bc6e ("util: port _mesa_strto[df] to C"), "make check" fails due to a missing _mesa_locale_init. Fixup this oversight. Signed-off-by: Erik Faye-Lund Tested-by: Vinson Lee --- src/glsl/test.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/test.cpp b/src/glsl/test.cpp