[Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-08 Thread Matt Turner
Notice our multiple values for M_PI_2, which rounded ...32 up to ...4 and ...5. --- src/glsl/builtin_functions.cpp | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 26ea923..3991f9d 100644

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Matt Turner
On Mon, Apr 7, 2014 at 11:39 AM, Ian Romanick wrote: > On 04/07/2014 10:28 AM, Aaron Watry wrote: >> On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner wrote: >>> Notice our multiple values for M_PI_2, which rounded ...32 up to >>> ...4 and ...5. >>> --- >>> The float casts are ugly. I tried to define

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Ian Romanick
On 04/07/2014 10:28 AM, Aaron Watry wrote: > On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner wrote: >> Notice our multiple values for M_PI_2, which rounded ...32 up to >> ...4 and ...5. >> --- >> The float casts are ugly. I tried to define M_PI_2f using the >> preprocessor -- something like >>#de

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Matt Turner
On Mon, Apr 7, 2014 at 10:28 AM, Aaron Watry wrote: > On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner wrote: >> Notice our multiple values for M_PI_2, which rounded ...32 up to >> ...4 and ...5. >> --- >> The float casts are ugly. I tried to define M_PI_2f using the >> preprocessor -- something like

Re: [Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Aaron Watry
On Mon, Apr 7, 2014 at 12:19 PM, Matt Turner wrote: > Notice our multiple values for M_PI_2, which rounded ...32 up to > ...4 and ...5. > --- > The float casts are ugly. I tried to define M_PI_2f using the > preprocessor -- something like >#define M_PI_2f M_PI_2##f > but no luck. > > src/glsl

[Mesa-dev] [PATCH] glsl: Use M_PI_* macros.

2014-04-07 Thread Matt Turner
Notice our multiple values for M_PI_2, which rounded ...32 up to ...4 and ...5. --- The float casts are ugly. I tried to define M_PI_2f using the preprocessor -- something like #define M_PI_2f M_PI_2##f but no luck. src/glsl/builtin_functions.cpp | 14 +++--- 1 file changed, 7 insertio