Re: [Mesa-dev] [PATCH] glsl: Rework interface block linking.

2013-11-14 Thread Jordan Justen
Reviewed-by: Jordan Justen On Wed, Oct 30, 2013 at 4:33 PM, Paul Berry wrote: > Previously, when doing intrastage and interstage interface block > linking, we only checked the interface type; this prevented us from > catching some link errors. > > We now check the following additional constraint

Re: [Mesa-dev] [PATCH] glsl: Rework interface block linking.

2013-11-14 Thread Ian Romanick
Man... linkers are the most complex pieces of software. :( I only have one significant comment (the second below) and three nits / questions. With at least the first one resolved, this patch is Reviewed-by: Ian Romanick On 10/30/2013 04:33 PM, Paul Berry wrote: > Previously, when doing intrasta

[Mesa-dev] [PATCH] glsl: Rework interface block linking.

2013-10-30 Thread Paul Berry
Previously, when doing intrastage and interstage interface block linking, we only checked the interface type; this prevented us from catching some link errors. We now check the following additional constraints: - For intrastage linking, the presence/absence of interface names must match. - For