Re: [Mesa-dev] [PATCH] glsl: Remove unused ast copy constructors.

2014-11-21 Thread Ilia Mirkin
On Fri, Nov 21, 2014 at 1:56 PM, Matt Turner wrote: > On Fri, Nov 21, 2014 at 10:52 AM, Ilia Mirkin wrote: >> On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner wrote: >>> These were added in commits a760c738 and 43757135 to be used in >>> implementing C-style aggregate initializers (commit 1b0d6aef).

Re: [Mesa-dev] [PATCH] glsl: Remove unused ast copy constructors.

2014-11-21 Thread Matt Turner
On Fri, Nov 21, 2014 at 10:52 AM, Ilia Mirkin wrote: > On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner wrote: >> These were added in commits a760c738 and 43757135 to be used in >> implementing C-style aggregate initializers (commit 1b0d6aef). Paul >> rewrote that code in commit 0da1a2cc to use GLSL

Re: [Mesa-dev] [PATCH] glsl: Remove unused ast copy constructors.

2014-11-21 Thread Ilia Mirkin
On Fri, Nov 21, 2014 at 1:47 PM, Matt Turner wrote: > These were added in commits a760c738 and 43757135 to be used in > implementing C-style aggregate initializers (commit 1b0d6aef). Paul > rewrote that code in commit 0da1a2cc to use GLSL types, rather than > AST types, leaving these copy construc

[Mesa-dev] [PATCH] glsl: Remove unused ast copy constructors.

2014-11-21 Thread Matt Turner
These were added in commits a760c738 and 43757135 to be used in implementing C-style aggregate initializers (commit 1b0d6aef). Paul rewrote that code in commit 0da1a2cc to use GLSL types, rather than AST types, leaving these copy constructors unused. Tested by making them private and providing no