Re: [Mesa-dev] [PATCH] glsl: Remove CSE pass.

2015-10-05 Thread Kenneth Graunke
On Saturday, October 03, 2015 10:57:38 AM Matt Turner wrote: > With NIR, it actually hurts things. > > total instructions in shared programs: 6529329 -> 652 (-0.01%) > instructions in affected programs: 14833 -> 14392 (-2.97%) > helped:299 > HURT:

Re: [Mesa-dev] [PATCH] glsl: Remove CSE pass.

2015-10-03 Thread Ilia Mirkin
On Sat, Oct 3, 2015 at 2:50 PM, Matt Turner wrote: > On Sat, Oct 3, 2015 at 11:31 AM, Ilia Mirkin wrote: >> On Sat, Oct 3, 2015 at 1:57 PM, Matt Turner wrote: >>> With NIR, it actually hurts things. >> >> Buuutt not everything uses NIR. > > Well... > >> Of course I'm sure it has a >> similar

Re: [Mesa-dev] [PATCH] glsl: Remove CSE pass.

2015-10-03 Thread Matt Turner
On Sat, Oct 3, 2015 at 11:31 AM, Ilia Mirkin wrote: > On Sat, Oct 3, 2015 at 1:57 PM, Matt Turner wrote: >> With NIR, it actually hurts things. > > Buuutt not everything uses NIR. Well... > Of course I'm sure it has a > similarly negative effect with nouveau/codegen, but I'm not so sure > a

Re: [Mesa-dev] [PATCH] glsl: Remove CSE pass.

2015-10-03 Thread Ilia Mirkin
On Sat, Oct 3, 2015 at 1:57 PM, Matt Turner wrote: > With NIR, it actually hurts things. Buuutt not everything uses NIR. Of course I'm sure it has a similarly negative effect with nouveau/codegen, but I'm not so sure about things like nv30 which don't have an optimizing compiler backend. IMHO

[Mesa-dev] [PATCH] glsl: Remove CSE pass.

2015-10-03 Thread Matt Turner
With NIR, it actually hurts things. total instructions in shared programs: 6529329 -> 652 (-0.01%) instructions in affected programs: 14833 -> 14392 (-2.97%) helped:299 HURT: 1 In all affected programs I inspected (including