Re: [Mesa-dev] [PATCH] glsl: Properly lex extra tokens when handling # directives.

2014-06-25 Thread Carl Worth
Kenneth Graunke writes: > That was the strangest bug I've tracked down in a while. A truly heroic debug effort, Ken! I recently ran into a bug or two in glcpp which were also running afoul of the annoying default lex rule. I'm about to publish my latest series of glcpp patches, but below is a p

Re: [Mesa-dev] [PATCH] glsl: Properly lex extra tokens when handling # directives.

2014-06-12 Thread Kenneth Graunke
On Wednesday, June 11, 2014 11:02:34 PM Matt Turner wrote: > How did you notice this? (More specifically than semicolons being > printed in your terminals!) > > Reviewed-by: Matt Turner I wrote a patch that altered the Meta GLSL clear shaders, and ran Piglit. Basically all of tests/hiz failed,

Re: [Mesa-dev] [PATCH] glsl: Properly lex extra tokens when handling # directives.

2014-06-11 Thread Matt Turner
How did you notice this? (More specifically than semicolons being printed in your terminals!) Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Properly lex extra tokens when handling # directives.

2014-06-11 Thread Kenneth Graunke
Without this, in the state, we would hit Flex's default rule, which prints tokens to stdout, rather than returning them as tokens. This manifested as a weird bug where shaders with semicolons after extension directives, such as: #extension GL_foo_bar : enable; would print semicolons to the s