Re: [Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-07-02 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Jun 27, 2014 at 2:21 AM, Chris Forbes wrote: > If another layout qualifier appeared to the left of `invocations` in the > GS input layout declaration, the invocation count would be dropped on > the floor. > > Fixes the piglit test: > > spec/ARB_transform_feedba

Re: [Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-06-27 Thread Chris Forbes
Also fixes spec/ARB_gpu_shader5/execution/invocations-conflicting Apparently my baseline... wasnt. On Sat, Jun 28, 2014 at 11:18 AM, Ilia Mirkin wrote: > On Fri, Jun 27, 2014 at 5:21 AM, Chris Forbes wrote: >> If another layout qualifier appeared to the left of `invocations` in the >> GS input

Re: [Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-06-27 Thread Ilia Mirkin
On Fri, Jun 27, 2014 at 5:21 AM, Chris Forbes wrote: > If another layout qualifier appeared to the left of `invocations` in the > GS input layout declaration, the invocation count would be dropped on > the floor. > > Fixes the piglit test: > > spec/ARB_transform_feedback3/arb_transform_feedback3-e

[Mesa-dev] [PATCH] glsl: Fix merging of layout(invocations) with other qualifiers

2014-06-27 Thread Chris Forbes
If another layout qualifier appeared to the left of `invocations` in the GS input layout declaration, the invocation count would be dropped on the floor. Fixes the piglit test: spec/ARB_transform_feedback3/arb_transform_feedback3-ext_interleaved_two_bufs_gs_max Signed-off-by: Chris Forbes Cc: I