Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-09 Thread Ian Romanick
On 09/05/2014 06:22 AM, Juha-Pekka Heikkila wrote: > Running fast clear glClear with SNB caused Valgrind to > complain about this. > > v2: line 237 fixed glClear from leaking memory, other > strdups are also now changed to ralloc_strdups but I > don't know what effect those have. At least no chang

[Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-05 Thread Juha-Pekka Heikkila
Running fast clear glClear with SNB caused Valgrind to complain about this. v2: line 237 fixed glClear from leaking memory, other strdups are also now changed to ralloc_strdups but I don't know what effect those have. At least no changes in my Piglit quick run. Signed-off-by: Juha-Pekka Heikkila

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-03 Thread Aras Pranckevicius
> > > --- a/src/glsl/glsl_lexer.ll > > +++ b/src/glsl/glsl_lexer.ll > > @@ -232,7 +232,8 @@ HASH^{SPC}#{SPC} > > [ \t\r]* { } > > : return COLON; > > [_a-zA-Z][_a-zA-Z0-9]* { > > - yylval->identifier

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-03 Thread Matt Turner
On Wed, Sep 3, 2014 at 7:03 AM, Juha-Pekka Heikkila wrote: > Running fast clear glClear with SNB caused Valgrind to > complain about this. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/glsl_lexer.ll | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/gls

[Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-03 Thread Juha-Pekka Heikkila
Running fast clear glClear with SNB caused Valgrind to complain about this. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/glsl_lexer.ll | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index b7c4aad..a9274a3 100644 --- a/src/