Re: [Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

2014-06-25 Thread Christoph Brill
Reviewed-by: Christoph Brill Am 25.06.2014 04:15 schrieb "Ian Romanick" : > From: Ian Romanick > > Mesa has an optimization that converts expressions like "v.x + v.y + v.z > + v.w" into dot(v, 1.0). And therein lies the rub: the other operand to > the dot-product is always a float... even if th

Re: [Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

2014-06-24 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

2014-06-24 Thread Kenneth Graunke
On Tuesday, June 24, 2014 07:15:00 PM Ian Romanick wrote: > From: Ian Romanick > > Mesa has an optimization that converts expressions like "v.x + v.y + v.z > + v.w" into dot(v, 1.0). And therein lies the rub: the other operand to > the dot-product is always a float... even if the vector is an iv

[Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

2014-06-24 Thread Ian Romanick
From: Ian Romanick Mesa has an optimization that converts expressions like "v.x + v.y + v.z + v.w" into dot(v, 1.0). And therein lies the rub: the other operand to the dot-product is always a float... even if the vector is an ivec or uvec. This results in an assertion failure in ir_builder. If