Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-21 Thread Kenneth Graunke
On Tuesday, October 21, 2014 08:05:43 AM Ian Romanick wrote: > I have this exact patch setting in me queue to send out. > > Reviewed-by: Ian Romanick > > I had initially thought about going the other way, and using the enums > instead of UniformBooleanTrue. I think the UniformBooleanTrue method

Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-21 Thread Ian Romanick
I have this exact patch setting in me queue to send out. Reviewed-by: Ian Romanick I had initially thought about going the other way, and using the enums instead of UniformBooleanTrue. I think the UniformBooleanTrue method is slightly more efficient since there is only one place where value con

Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-16 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-16 Thread Tapani
Reviewed-by: Tapani Pälli On 10/16/2014 07:28 PM, Kenneth Graunke wrote: A while back, Matt made the uniform upload functions simply upload ctx->Const.UniformBooleanTrue for boolean values instead of 0/1, which removed the need to convert it later. We also set UniformBooleanTrue to 1.0f for dr

[Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.

2014-10-16 Thread Kenneth Graunke
A while back, Matt made the uniform upload functions simply upload ctx->Const.UniformBooleanTrue for boolean values instead of 0/1, which removed the need to convert it later. We also set UniformBooleanTrue to 1.0f for drivers which want to treat booleans as 0.0/1.0f. Nothing ever sets these, so