Re: [Mesa-dev] [PATCH] glsl: Check that layout is non-null before dereferencing.

2016-05-16 Thread Timothy Arceri
On Mon, 2016-05-16 at 14:51 -0700, Matt Turner wrote: > It's checked everywhere else. Maybe is_interface implies layout is > non-null. Likely not worth it. Yeah is should only be null for structs. If it shuts up Coverity: Reviewed-by: Timothy Arceri > > Found by Coverity (CID 1358495). > --- >

[Mesa-dev] [PATCH] glsl: Check that layout is non-null before dereferencing.

2016-05-16 Thread Matt Turner
It's checked everywhere else. Maybe is_interface implies layout is non-null. Likely not worth it. Found by Coverity (CID 1358495). --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_h