Re: [Mesa-dev] [PATCH] glsl: Actually enforce ES SSBO unsized array check for SSBOs.

2017-02-10 Thread Kenneth Graunke
On Friday, February 10, 2017 3:01:10 PM PST Ilia Mirkin wrote: > Seems pretty similar to https://patchwork.freedesktop.org/patch/138274/ So it does! I hadn't seen that patch yet. I just pushed his patch instead with my R-b. Thanks! signature.asc Description: This is a digitally signed message

Re: [Mesa-dev] [PATCH] glsl: Actually enforce ES SSBO unsized array check for SSBOs.

2017-02-10 Thread Ilia Mirkin
Seems pretty similar to https://patchwork.freedesktop.org/patch/138274/ On Fri, Feb 10, 2017 at 5:48 PM, Kenneth Graunke wrote: > Commit b010fa85675b98962426fe8961466fbae2d25499 re-added this check > after it was erroneously dropped while fixing another bug. However, > the control flow was sligh

[Mesa-dev] [PATCH] glsl: Actually enforce ES SSBO unsized array check for SSBOs.

2017-02-10 Thread Kenneth Graunke
Commit b010fa85675b98962426fe8961466fbae2d25499 re-added this check after it was erroneously dropped while fixing another bug. However, the control flow was slightly off, and it ended up only applying to UBOs and not SSBOs. Fixes dEQP-GLES31.functional.debug.negative_coverage. {callbacks,get_erro