Re: [Mesa-dev] [PATCH] glsl/linker: fix output variable overlap check

2017-09-20 Thread Mark Janes
This patch regressed piglit and gl cts tests for the i965 driver https://bugs.freedesktop.org/show_bug.cgi?id=102904 Nicolai Hähnle writes: > From: Nicolai Hähnle > > Prevent an overflow caused by too many output variables. To limit the > scope of the issue, write to the assigned array only fo

Re: [Mesa-dev] [PATCH] glsl/linker: fix output variable overlap check

2017-09-18 Thread Timothy Arceri
This seems reasonable, thanks for fixing. Maybe just add a comment in the code also. /* 12 * 4 == (max # of FS outputs) * max components */ Or something similar. Reviewed-by: Timothy Arceri On 18/09/17 19:30, Nicolai Hähnle wrote: From: Nicolai Hähnle Prevent an overflow caused by too man

[Mesa-dev] [PATCH] glsl/linker: fix output variable overlap check

2017-09-18 Thread Nicolai Hähnle
From: Nicolai Hähnle Prevent an overflow caused by too many output variables. To limit the scope of the issue, write to the assigned array only for the non-ES fragment shader path, which is the only place where it's needed. Since the function will bail with an error when output variables with ov