Re: [Mesa-dev] [PATCH] glsl/cache: correct asprintf error handling

2016-11-04 Thread Edward O'Callaghan
Good spot, Reviewed-by: Edward O'Callaghan On 11/03/2016 09:03 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > From the manpage of asprintf: > >"If memory allocation wasn't possible, or some other error occurs, > these functions will return -1, and the contents of strp are > u

Re: [Mesa-dev] [PATCH] glsl/cache: correct asprintf error handling

2016-11-03 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2016-11-03 at 11:03 +0100, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > From the manpage of asprintf: > >    "If memory allocation wasn't possible, or some other error occurs, > these functions will return -1, and the contents of strp are > u

[Mesa-dev] [PATCH] glsl/cache: correct asprintf error handling

2016-11-03 Thread Nicolai Hähnle
From: Nicolai Hähnle From the manpage of asprintf: "If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp are undefined." --- src/compiler/glsl/cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di