Re: [Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

2017-03-26 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 03/27/2017 11:42 AM, Timothy Arceri wrote: > > > On 27/03/17 10:18, Grazvydas Ignotas wrote: >> On Sun, Mar 26, 2017 at 11:45 PM, Timothy Arceri >> wrote: >>> >>> >>> On 27/03/17 03:30, Grazvydas Ignotas wrote: The checks were only looking at the fi

Re: [Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

2017-03-26 Thread Timothy Arceri
On 27/03/17 10:18, Grazvydas Ignotas wrote: On Sun, Mar 26, 2017 at 11:45 PM, Timothy Arceri wrote: On 27/03/17 03:30, Grazvydas Ignotas wrote: The checks were only looking at the first byte, while the intention seems to be to check if the whole sha1 is zero. This prevented all shaders wi

Re: [Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

2017-03-26 Thread Grazvydas Ignotas
On Sun, Mar 26, 2017 at 11:45 PM, Timothy Arceri wrote: > > > On 27/03/17 03:30, Grazvydas Ignotas wrote: >> >> The checks were only looking at the first byte, while the intention >> seems to be to check if the whole sha1 is zero. This prevented all >> shaders with first byte zero in their sha1 fr

Re: [Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

2017-03-26 Thread Timothy Arceri
On 27/03/17 03:30, Grazvydas Ignotas wrote: The checks were only looking at the first byte, while the intention seems to be to check if the whole sha1 is zero. This prevented all shaders with first byte zero in their sha1 from being saved. This shaves around a second from Deus Ex load time on

[Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

2017-03-26 Thread Grazvydas Ignotas
The checks were only looking at the first byte, while the intention seems to be to check if the whole sha1 is zero. This prevented all shaders with first byte zero in their sha1 from being saved. This shaves around a second from Deus Ex load time on a hot cache. Signed-off-by: Grazvydas Ignotas