Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number

2017-06-05 Thread Vlad Golovkin
2017-06-02 17:59 GMT+03:00 Emil Velikov : > On 2 June 2017 at 14:56, Vlad Golovkin wrote: >> -- Forwarded message -- >> From: Vlad Golovkin >> Date: 2017-06-02 16:55 GMT+03:00 >> Subject: Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadec

Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number

2017-06-02 Thread Emil Velikov
On 2 June 2017 at 14:56, Vlad Golovkin wrote: > -- Forwarded message -- > From: Vlad Golovkin > Date: 2017-06-02 16:55 GMT+03:00 > Subject: Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal > number > To: Emil Velikov > > > 2017-06-02 1

Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number

2017-06-02 Thread Emil Velikov
Hi Vlad, Welcome to Mesa. Have you don't any benchmarking on this patch via something like shader-db [1]? Mentioning the results in the commit message is encouraged. On 2 June 2017 at 13:37, Vlad Golovkin wrote: > This will make it possible to remove unnecessary strlen and strncmp > calls. > --

[Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number

2017-06-02 Thread Vlad Golovkin
This will make it possible to remove unnecessary strlen and strncmp calls. --- src/compiler/glsl/glcpp/glcpp-parse.y | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y b/src/compiler/glsl/glcpp/glcpp-parse.y index fe211a0f0b..8cdd4