I should have a fix for all of these problems out in about an hour. I'm
just running it through the CI now.
On 11/05/2016 02:48 AM, Karol Herbst wrote:
> 2016-11-05 2:50 GMT+01:00 Ian Romanick :
>> (Sorry about the top post. Sent from my phone.)
>>
>> That expression will allow versions like 0130
On Tue, 2016-11-08 at 14:19 +0100, Karol Herbst wrote:
> well I don't care either way, maybe the spec does say anything about
> it.
I was re-reading GLSL 1.10 spec about #version directive.
#version follows the same convention as __VERSION__
For __VERSION___, spec says "will substitute a decimal
2016-11-08 13:35 GMT+01:00 Juan A. Suarez Romero :
> On Sat, 2016-11-05 at 10:48 +0100, Karol Herbst wrote:
>> "#version 0512": 0:1(10): error: GLSL 3.30 is not supported.
>> Supported
>> versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES
>>
>> so the issue with this would be, that "0512" is pars
On Sat, 2016-11-05 at 10:48 +0100, Karol Herbst wrote:
> "#version 0512": 0:1(10): error: GLSL 3.30 is not supported.
> Supported
> versions are: 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES
>
> so the issue with this would be, that "0512" is parsed as 3.30, which
> isn't right either, but the current m
2016-11-07 10:05 GMT+01:00 Juan A. Suarez Romero :
> On Sat, 2016-11-05 at 10:48 +0100, Karol Herbst wrote:
>> 2016-11-05 2:50 GMT+01:00 Ian Romanick :
>> > (Sorry about the top post. Sent from my phone.)
>> >
>> > That expression will allow versions like 0130 as valid. If you
>> just want to
>> >
On Sat, 2016-11-05 at 10:48 +0100, Karol Herbst wrote:
> 2016-11-05 2:50 GMT+01:00 Ian Romanick :
> > (Sorry about the top post. Sent from my phone.)
> >
> > That expression will allow versions like 0130 as valid. If you
> just want to
> > allow 0, you need a more complex regular expression. I fe
2016-11-05 2:50 GMT+01:00 Ian Romanick :
> (Sorry about the top post. Sent from my phone.)
>
> That expression will allow versions like 0130 as valid. If you just want to
> allow 0, you need a more complex regular expression. I feel like that's
> just a bandage... what about other bad values like
(Sorry about the top post. Sent from my phone.)
That expression will allow versions like 0130 as valid. If you just want
to allow 0, you need a more complex regular expression. I feel like that's
just a bandage... what about other bad values like "#version -130"? Won't
that have the same pr
On Fri, 2016-11-04 at 16:57 +0100, Karol Herbst wrote:
> for reference the bug I've created for this:
> https://bugs.freedesktop.org/show_bug.cgi?id=97420
>
>
I'll tag the commit with this bug.
J.A.
___
mesa-dev mailing list
mesa-dev@lists.f
for reference the bug I've created for this:
https://bugs.freedesktop.org/show_bug.cgi?id=97420
and thanks for fixing this
2016-11-04 13:22 GMT+01:00 Juan A. Suarez Romero :
> Shader can define #version as an integer, including 0.
>
> Initializes version to -1 to know later if shader has defined
On Fri, 2016-11-04 at 14:09 +, Eric Engestrom wrote:
> On Friday, 2016-11-04 13:22:07 +0100, Juan A. Suarez Romero wrote:
> >
> > Shader can define #version as an integer, including 0.
> >
> > Initializes version to -1 to know later if shader has defined a
> > #version
> > or not.
> >
> > It
On Friday, 2016-11-04 13:22:07 +0100, Juan A. Suarez Romero wrote:
> Shader can define #version as an integer, including 0.
>
> Initializes version to -1 to know later if shader has defined a #version
> or not.
>
> It fixes 4 piglit tests:
> spec/glsl-1.10/compiler/version-0.frag: crash pass
>
Shader can define #version as an integer, including 0.
Initializes version to -1 to know later if shader has defined a #version
or not.
It fixes 4 piglit tests:
spec/glsl-1.10/compiler/version-0.frag: crash pass
spec/glsl-1.10/compiler/version-0.vert: crash pass
spec/glsl-es-3.00/compiler/v
13 matches
Mail list logo
