Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-12-17 Thread Erik Faye-Lund
On Fri, Oct 11, 2013 at 10:48 PM, Ian Romanick wrote: > Carl, > > Can you look at this patch and Erik's follow-up patch? You (still) know > the glcpp much better than any of the rest of us. > > (Carl is currently out of town, so I know his response will be slow...) > I guess "slow" doesn't mean

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-10-11 Thread Ian Romanick
Carl, Can you look at this patch and Erik's follow-up patch? You (still) know the glcpp much better than any of the rest of us. (Carl is currently out of town, so I know his response will be slow...) Thanks. On 09/23/2013 01:35 PM, Erik Faye-Lund wrote: > The preprocessor currently eats multip

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-10-11 Thread Erik Faye-Lund
On Mon, Sep 23, 2013 at 11:02 PM, Erik Faye-Lund wrote: > On Mon, Sep 23, 2013 at 10:35 PM, Erik Faye-Lund wrote: >> The preprocessor currently eats multiple #else directives >> int the same #if(def) ... #endif block. While I haven't been able >> to find anything that explicitly disallows it, it'

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-09-23 Thread Erik Faye-Lund
On Mon, Sep 23, 2013 at 10:35 PM, Erik Faye-Lund wrote: > The preprocessor currently eats multiple #else directives > int the same #if(def) ... #endif block. While I haven't been able > to find anything that explicitly disallows it, it's nonsensical > and should probably not be allowed. > > Add ch

[Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-09-23 Thread Erik Faye-Lund
The preprocessor currently eats multiple #else directives int the same #if(def) ... #endif block. While I haven't been able to find anything that explicitly disallows it, it's nonsensical and should probably not be allowed. Add checks to reject the code. --- I'm not entirely sure why parser->skip