Re: [Mesa-dev] [PATCH] glcpp: Pass through #line directives.

2012-06-09 Thread Carl Worth
Kenneth Graunke writes: > One bad thing about this patch is that it breaks 091-hash-line.c in glcpp's > unit test suite. I'm not sure what to do about that. I could update the > output, but the new output doesn't make much sense anymore...it gives you > lovely messages like: > > 0:4(1): prep

Re: [Mesa-dev] [PATCH] glcpp: Pass through #line directives.

2012-06-06 Thread Carl Worth
Kenneth Graunke writes: > One bad thing about this patch is that it breaks 091-hash-line.c in glcpp's > unit test suite. I'm not sure what to do about that. I could update the > output, but the new output doesn't make much sense anymore...it gives you > lovely messages like: > > 0:4(1): prep

[Mesa-dev] [PATCH] glcpp: Pass through #line directives.

2012-06-06 Thread Kenneth Graunke
>From the GLSL 1.10 specification: #line must have, after macro substitution, one of the following forms: #line line #line line source-string-number" Previously, we handled #line directives completely within the glcpp lexer, which obviously precludes proper macro substitu