Re: [Mesa-dev] [PATCH] glcpp: Fix locations when encounting "#".

2016-03-09 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2016-03-08 at 19:09 -0800, Kenneth Graunke wrote: > We were failing to reset our location tracking when encountering a > NEWLINE in the state. Rip the code from the <*>{NEWLINE} rule, > which handles this properly. > > Also, update 146-version-first-hash

[Mesa-dev] [PATCH] glcpp: Fix locations when encounting "#".

2016-03-08 Thread Kenneth Graunke
We were failing to reset our location tracking when encountering a NEWLINE in the state. Rip the code from the <*>{NEWLINE} rule, which handles this properly. Also, update 146-version-first-hash.c to have proper expectations. When I introduced the test, I didn't verify that the line/column numbe