Re: [Mesa-dev] [PATCH] gbm: avoid null pointer dereference

2017-07-17 Thread Mun, Gwan-gyeong
Thanks Daniel for a detailed explain with link, that was totally my misunderstood. ignore this patch ^^. 2017-07-17 23:20 GMT+09:00 Daniel Stone : > Hi, > > On 17 July 2017 at 15:02, Gwan-gyeong Mun wrote: >> gbm_dri_surface_create() might create gbm_surface without modifiers. >> therefore, gbm_

Re: [Mesa-dev] [PATCH] gbm: avoid null pointer dereference

2017-07-17 Thread Daniel Stone
Hi, On 17 July 2017 at 15:02, Gwan-gyeong Mun wrote: > gbm_dri_surface_create() might create gbm_surface without modifiers. > therefore, gbm_dri_surface_destroy() needs to check modifiers is null or not > prior to free it. This is not true. The code here does not perform a dereference of surf->b

[Mesa-dev] [PATCH] gbm: avoid null pointer dereference

2017-07-17 Thread Gwan-gyeong Mun
gbm_dri_surface_create() might create gbm_surface without modifiers. therefore, gbm_dri_surface_destroy() needs to check modifiers is null or not prior to free it. Signed-off-by: Mun Gwan-gyeong --- src/gbm/backends/dri/gbm_dri.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi