Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-30 Thread Emil Velikov
On 29 March 2017 at 13:34, Emil Velikov wrote: > On 29 March 2017 at 13:02, Thomas Hellstrom wrote: >> Hi, Emil, >> >> On 03/29/2017 01:30 PM, Emil Velikov wrote: >>> Hi Thomas, >>> >>> On 28 March 2017 at 20:39, Thomas Hellstrom wrote: Drivers may queue dma operations on the context at unm

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-30 Thread Michel Dänzer
On 30/03/17 05:09 PM, Thomas Hellstrom wrote: > On 03/30/2017 05:48 AM, Michel Dänzer wrote: >> On 30/03/17 12:56 AM, Thomas Hellstrom wrote: >>> On 03/29/2017 02:34 PM, Emil Velikov wrote: On 29 March 2017 at 13:02, Thomas Hellstrom wrote: > On 03/29/2017 01:30 PM, Emil Velikov wrote: >>

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-30 Thread Thomas Hellstrom
On 03/30/2017 05:48 AM, Michel Dänzer wrote: > On 30/03/17 12:56 AM, Thomas Hellstrom wrote: >> On 03/29/2017 02:34 PM, Emil Velikov wrote: >>> On 29 March 2017 at 13:02, Thomas Hellstrom wrote: On 03/29/2017 01:30 PM, Emil Velikov wrote: > On 28 March 2017 at 20:39, Thomas Hellstrom wro

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Michel Dänzer
On 30/03/17 12:56 AM, Thomas Hellstrom wrote: > On 03/29/2017 02:34 PM, Emil Velikov wrote: >> On 29 March 2017 at 13:02, Thomas Hellstrom wrote: >>> On 03/29/2017 01:30 PM, Emil Velikov wrote: On 28 March 2017 at 20:39, Thomas Hellstrom wrote: > > Signed-off-by: Thomas Hellstrom >>

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Thomas Hellstrom
Hi, Emil, On 03/29/2017 02:34 PM, Emil Velikov wrote: > On 29 March 2017 at 13:02, Thomas Hellstrom wrote: >> Hi, Emil, >> >> On 03/29/2017 01:30 PM, Emil Velikov wrote: >>> Hi Thomas, >>> >>> On 28 March 2017 at 20:39, Thomas Hellstrom wrote: Drivers may queue dma operations on the context

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Emil Velikov
On 29 March 2017 at 13:02, Thomas Hellstrom wrote: > Hi, Emil, > > On 03/29/2017 01:30 PM, Emil Velikov wrote: >> Hi Thomas, >> >> On 28 March 2017 at 20:39, Thomas Hellstrom wrote: >>> Drivers may queue dma operations on the context at unmap time so we need >>> to flush to make sure the data get

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Thomas Hellstrom
Hi, Emil, On 03/29/2017 01:30 PM, Emil Velikov wrote: > Hi Thomas, > > On 28 March 2017 at 20:39, Thomas Hellstrom wrote: >> Drivers may queue dma operations on the context at unmap time so we need >> to flush to make sure the data gets to the bo. Ideally the application >> would take care of thi

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Emil Velikov
Hi Thomas, On 28 March 2017 at 20:39, Thomas Hellstrom wrote: > Drivers may queue dma operations on the context at unmap time so we need > to flush to make sure the data gets to the bo. Ideally the application > would take care of this, but since there appears to be no exported gbm > flush functi

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Mar 28, 2017 at 9:39 PM, Thomas Hellstrom wrote: > Drivers may queue dma operations on the context at unmap time so we need > to flush to make sure the data gets to the bo. Ideally the application > would take care of this, but since there appears to be no

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Thomas Hellstrom
On 03/28/2017 10:36 PM, Eric Anholt wrote: > Thomas Hellstrom writes: > >> Drivers may queue dma operations on the context at unmap time so we need >> to flush to make sure the data gets to the bo. Ideally the application >> would take care of this, but since there appears to be no exported gbm >>

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-28 Thread Eric Anholt
Thomas Hellstrom writes: > Drivers may queue dma operations on the context at unmap time so we need > to flush to make sure the data gets to the bo. Ideally the application > would take care of this, but since there appears to be no exported gbm > flush functionality we need to explicitly flush a

[Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-28 Thread Thomas Hellstrom
Drivers may queue dma operations on the context at unmap time so we need to flush to make sure the data gets to the bo. Ideally the application would take care of this, but since there appears to be no exported gbm flush functionality we need to explicitly flush at unmap time. This fixes a problem