Re: [Mesa-dev] [PATCH] gallivm: unify sin and cos implementation

2013-08-21 Thread Roland Scheidegger
Am 21.08.2013 02:05, schrieb Roland Mainz: > On Wed, Aug 21, 2013 at 1:45 AM, Roland Scheidegger > wrote: >> Am 21.08.2013 01:28, schrieb Roland Mainz: >>> On Wed, Aug 21, 2013 at 1:12 AM, wrote: From: Roland Scheidegger > [snip] >>> Can you check whether the new code supports -nan correc

Re: [Mesa-dev] [PATCH] gallivm: unify sin and cos implementation

2013-08-20 Thread Roland Mainz
On Wed, Aug 21, 2013 at 1:45 AM, Roland Scheidegger wrote: > Am 21.08.2013 01:28, schrieb Roland Mainz: >> On Wed, Aug 21, 2013 at 1:12 AM, wrote: >>> From: Roland Scheidegger [snip] >> Can you check whether the new code supports -nan correctly, please >> (-nan is used by scientific software...

Re: [Mesa-dev] [PATCH] gallivm: unify sin and cos implementation

2013-08-20 Thread Roland Scheidegger
Am 21.08.2013 01:28, schrieb Roland Mainz: > On Wed, Aug 21, 2013 at 1:12 AM, wrote: >> From: Roland Scheidegger >> >> The (complicated!) math is all identical, there's just minimal differences >> how >> sign bit is calculated plus there's an additional subtraction for the >> argument >> going

Re: [Mesa-dev] [PATCH] gallivm: unify sin and cos implementation

2013-08-20 Thread Roland Mainz
On Wed, Aug 21, 2013 at 1:12 AM, wrote: > From: Roland Scheidegger > > The (complicated!) math is all identical, there's just minimal differences how > sign bit is calculated plus there's an additional subtraction for the argument > going into the polynomial for cos. > The logic stays 100% the s

[Mesa-dev] [PATCH] gallivm: unify sin and cos implementation

2013-08-20 Thread sroland
From: Roland Scheidegger The (complicated!) math is all identical, there's just minimal differences how sign bit is calculated plus there's an additional subtraction for the argument going into the polynomial for cos. The logic stays 100% the same (with a small exception, sign bit calculation for