Re: [Mesa-dev] [PATCH] gallivm: fix texel fetch for array textures (2)

2012-12-14 Thread Dave Airlie
On Sat, Dec 15, 2012 at 6:25 AM, wrote: > From: Roland Scheidegger > > a460aea3f14222af46f88d1bc686f82180b8a872 wasn't entirely correct, > since all coords are already ints hence need to skip the iround. > Passes piglit texelFetch with sampler1DArray/sampler2DArray. > --- > src/gallium/auxiliar

[Mesa-dev] [PATCH] gallivm: fix texel fetch for array textures (2)

2012-12-14 Thread sroland
From: Roland Scheidegger a460aea3f14222af46f88d1bc686f82180b8a872 wasn't entirely correct, since all coords are already ints hence need to skip the iround. Passes piglit texelFetch with sampler1DArray/sampler2DArray. --- src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c |5 +++-- 1 file chan

Re: [Mesa-dev] [PATCH] gallivm: fix texel fetch for array textures

2012-12-12 Thread Roland Scheidegger
I was wrong that there is no test for this in piglit. spec/glsl-1.30/execution/fs-texelFetch-2D.c (and the offset version) only test 2d samplers, but texturing/shaders/texelFetch.c can test all samplers, in both fs and vs. It currently crashes though with llvmpipe (using glsl and GL version overrid

Re: [Mesa-dev] [PATCH] gallivm: fix texel fetch for array textures

2012-12-12 Thread Jose Fonseca
Looks good AFAICT. Maybe we should add a test for this in piglit? Jose - Original Message - > From: Roland Scheidegger > > Since we don't call lp_build_sample_common() in the texel fetch path > we missed > the layer fixup code. If someone would have tried to do texelFetch > with array

[Mesa-dev] [PATCH] gallivm: fix texel fetch for array textures

2012-12-10 Thread sroland
From: Roland Scheidegger Since we don't call lp_build_sample_common() in the texel fetch path we missed the layer fixup code. If someone would have tried to do texelFetch with array textures it would have crashed for sure. Not really tested (no overlap of texelFetch and array texture tests in pig