Re: [Mesa-dev] [PATCH] gallivm: fix broken 8-wide s3tc decoding

2019-05-07 Thread Jose Fonseca
LGTM. Reviewed-by: Jose Fonseca From: srol...@vmware.com Sent: Tuesday, May 7, 2019 03:12 To: Jose Fonseca; Brian Paul; mesa-dev@lists.freedesktop.org Cc: Roland Scheidegger Subject: [PATCH] gallivm: fix broken 8-wide s3tc decoding From: Roland Scheidegger Br

Re: [Mesa-dev] [PATCH] gallivm: fix broken 8-wide s3tc decoding

2019-05-06 Thread Brian Paul
LGTM. Just two little nits below. Reviewed-by: Brian Paul Perhaps you could review the 5-patch series of clean-ups I posted on Saturday? On 05/06/2019 06:12 PM, srol...@vmware.com wrote: From: Roland Scheidegger Brian noticed there was an uninitialized var for the 8-wide case and 128 b

[Mesa-dev] [PATCH] gallivm: fix broken 8-wide s3tc decoding

2019-05-06 Thread sroland
From: Roland Scheidegger Brian noticed there was an uninitialized var for the 8-wide case and 128 bit blocks, which made it always crash. Likewise, the 64bit block case had another crash bug due to type mismatch. Color decode (used for all s3tc formats) also had a bogus shuffle for this case, lea