Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-11 Thread Stéphane Marchesin
On Thu, Oct 11, 2012 at 3:00 PM, Marek Olšák wrote: > On Thu, Oct 11, 2012 at 10:05 PM, Stéphane Marchesin > wrote: >> On Tue, Oct 9, 2012 at 6:04 PM, Marek Olšák wrote: >>> Hi, >>> >>> this is actually a very small cleanup that got unexpectedly big. I >>> really underestimated the size of galli

Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-11 Thread Marek Olšák
On Thu, Oct 11, 2012 at 10:05 PM, Stéphane Marchesin wrote: > On Tue, Oct 9, 2012 at 6:04 PM, Marek Olšák wrote: >> Hi, >> >> this is actually a very small cleanup that got unexpectedly big. I >> really underestimated the size of gallium. >> >> It's part of the plan discussed here: >> http://www.

Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-11 Thread Andy Furniss
Marek Olšák wrote: Hi, this is actually a very small cleanup that got unexpectedly big. I really underestimated the size of gallium. Build nit - make[3]: Entering directory `/home/andy/Src/Mesa-git/mesa/src/gallium/auxiliary' gcc -c -I. -I../../../src/gallium/include -I../../../src/gallium/

Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-11 Thread Stéphane Marchesin
On Tue, Oct 9, 2012 at 6:04 PM, Marek Olšák wrote: > Hi, > > this is actually a very small cleanup that got unexpectedly big. I > really underestimated the size of gallium. > > It's part of the plan discussed here: > http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg17930.html > > The

Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-11 Thread Jose Fonseca
- Original Message - > Hi, > > this is actually a very small cleanup that got unexpectedly big. I > really underestimated the size of gallium. > > It's part of the plan discussed here: > http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg17930.html > > The idea is that get_t

Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-11 Thread Brian Paul
On 10/09/2012 07:04 PM, Marek Olšák wrote: Hi, this is actually a very small cleanup that got unexpectedly big. I really underestimated the size of gallium. It's part of the plan discussed here: http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg17930.html The idea is that get_trans

Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-10 Thread Marek Olšák
One thing to note here. Some Gallium modules already work even if the returned transfer object is NULL. The drivers where transfer_unmap for PIPE_BUFFER is actually no-op would benefit from this by skipping the allocation of pipe_transfer entirely. It's not recommended to use such a hack now, but i

Re: [Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-10 Thread Michel Dänzer
On Mit, 2012-10-10 at 03:04 +0200, Marek Olšák wrote: > > this is actually a very small cleanup that got unexpectedly big. I > really underestimated the size of gallium. We used to do this sort of rework a lot in the early days of Gallium, good thing it's settled down a bit. :) > It's part of

[Mesa-dev] [PATCH] gallium: unify transfer functions

2012-10-09 Thread Marek Olšák
Hi, this is actually a very small cleanup that got unexpectedly big. I really underestimated the size of gallium. It's part of the plan discussed here: http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg17930.html The idea is that get_transfer+transfer_map is folded into transfer_map,