Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-07 Thread Kollarova, Martina
On Wed, 2016-09-07 at 07:38 +, Michel Dänzer wrote: > On 07/09/16 12:29 AM, Nicolai Hähnle wrote: > > On 06.09.2016 16:37, Martina Kollarova wrote: > >> 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] > >> 2. Comparison of constant -1 with expression of type 'unsigned int'

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-07 Thread Nicolai Hähnle
On 07.09.2016 14:40, Jan Vesely wrote: On Wed, 2016-09-07 at 10:12 +0200, Nicolai Hähnle wrote: On 07.09.2016 09:38, Michel Dänzer wrote: On 07/09/16 12:29 AM, Nicolai Hähnle wrote: On 06.09.2016 16:37, Martina Kollarova wrote: 1. Variable 'hole' is uninitialized when used here [- Wuniniti

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-07 Thread Jan Vesely
On Wed, 2016-09-07 at 10:12 +0200, Nicolai Hähnle wrote: > On 07.09.2016 09:38, Michel Dänzer wrote: > > > > On 07/09/16 12:29 AM, Nicolai Hähnle wrote: > > > > > > On 06.09.2016 16:37, Martina Kollarova wrote: > > > > > > > > 1. Variable 'hole' is uninitialized when used here [- > > > > Wuninit

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-07 Thread Nicolai Hähnle
On 07.09.2016 09:38, Michel Dänzer wrote: On 07/09/16 12:29 AM, Nicolai Hähnle wrote: On 06.09.2016 16:37, Martina Kollarova wrote: 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] 2. Comparison of constant -1 with expression of type 'unsigned int' is always false [-Wtaut

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-07 Thread Michel Dänzer
On 07/09/16 12:29 AM, Nicolai Hähnle wrote: > On 06.09.2016 16:37, Martina Kollarova wrote: >> 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] >> 2. Comparison of constant -1 with expression of type 'unsigned int' is >> always >>false [-Wtautological-constant-out-of-range-c

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-06 Thread Nicolai Hähnle
On 06.09.2016 16:37, Martina Kollarova wrote: 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] 2. Comparison of constant -1 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare] --- src/gallium/winsys/radeon/drm/radeon_drm_bo

[Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-06 Thread Martina Kollarova
1. Variable 'hole' is uninitialized when used here [-Wuninitialized] 2. Comparison of constant -1 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare] --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 +- src/gallium/winsys/sw/kms-dri/kms