Re: [Mesa-dev] [PATCH] gallium: Mute arrays for several meta like callbacks v3

2018-02-08 Thread Mathias Fröhlich
Good Morning, Thanks to you both for the review! On Thursday, 8 February 2018 21:39:11 CET Marek Olšák wrote: > What is "not perfect" about it? It looks good to me. Well, Brian mentioned that we can probably skip more stages in this case. But I did not take the time to understand which ones in de

Re: [Mesa-dev] [PATCH] gallium: Mute arrays for several meta like callbacks v3

2018-02-08 Thread Marek Olšák
What is "not perfect" about it? It looks good to me. Reviewed-by: Marek Olšák Marek On Thu, Feb 8, 2018 at 7:55 PM, wrote: > From: Mathias Fröhlich > > Hi Marek, > > you mean like this? > Well, not perfect but that survives piglit quick on radeonsi then. > > Please review > > best and thanks

[Mesa-dev] [PATCH] gallium: Mute arrays for several meta like callbacks v3

2018-02-08 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Marek, you mean like this? Well, not perfect but that survives piglit quick on radeonsi then. Please review best and thanks Mathias Set the _DrawArray pointer to NULL when calling into the Drivers Bitmap/CopyPixels/DrawAtlasBitmaps/DrawPixels/DrawTex hooks. This f

Re: [Mesa-dev] [PATCH] gallium: Mute arrays for several meta like callbacks.

2018-02-06 Thread Marek Olšák
You probably want to add new ST_PIPELINE_xxx. See how state filtering works with ST_PIPELINE_CLEAR. Marek On Tue, Feb 6, 2018 at 9:18 PM, wrote: > From: Mathias Fröhlich > > Hi Brian, > > I think you are right the _mesa_set_drawing_arrays better belong into > the state tracker. You mean like t

[Mesa-dev] [PATCH] gallium: Mute arrays for several meta like callbacks.

2018-02-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Brian, I think you are right the _mesa_set_drawing_arrays better belong into the state tracker. You mean like the below? I added also two other callbacks that lookes suspicious to me. I just sent the single patch in question out of the series of three. Tested with pigli