Re: [Mesa-dev] [PATCH] gallium/util: initialize pipe_framebuffer_state to zeros

2016-04-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Apr 15, 2016 at 8:15 PM, Brian Paul wrote: > To silence a valgrind uninitialized memory warning. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94955 > Cc: "11.1 11.2" > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] gallium/util: initialize pipe_framebuffer_state to zeros

2016-04-15 Thread Brian Paul
According to the p_state.h file, unsigned samples; /**< Number of samples in a no-attachment framebuffer */ unsigned layers; /**< Number of layers in a no-attachment framebuffer */ so since the fb has attachments here, I think those fields are unused. Cc'ing Edward since he added the

Re: [Mesa-dev] [PATCH] gallium/util: initialize pipe_framebuffer_state to zeros

2016-04-15 Thread Ilia Mirkin
Should it instead properly initialize fb->samples/layers? On Fri, Apr 15, 2016 at 2:15 PM, Brian Paul wrote: > To silence a valgrind uninitialized memory warning. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94955 > Cc: "11.1 11.2" > --- > src/gallium/auxiliary/util/u_blitter.c |

[Mesa-dev] [PATCH] gallium/util: initialize pipe_framebuffer_state to zeros

2016-04-15 Thread Brian Paul
To silence a valgrind uninitialized memory warning. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94955 Cc: "11.1 11.2" --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/au