Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

2017-07-27 Thread Marek Olšák
On Thu, Jul 27, 2017 at 10:29 PM, Roland Scheidegger wrote: > Ok, I suppose that makes sense. > I just wouldn't be surprised if some driver instead just relies on the > set_min_samples() value all the time and ignoring it should really run > at per sample frequency in any case. > > Reviewed-by: Ro

Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

2017-07-27 Thread Roland Scheidegger
Ok, I suppose that makes sense. I just wouldn't be surprised if some driver instead just relies on the set_min_samples() value all the time and ignoring it should really run at per sample frequency in any case. Reviewed-by: Roland Scheidegger Am 27.07.2017 um 21:31 schrieb Brian Paul: > The DX1

Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

2017-07-27 Thread Brian Paul
The DX10.1 docs specify this, and there's language in both the GL_ARB_sample_shading and GLSL 4.00 specs that this behavior is expected. I think it makes sense to say the same for gallium. Mesa's _mesa_get_min_invocations_per_fragment() returns N samples when the FS uses the sample ID or posi

Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

2017-07-27 Thread Roland Scheidegger
Are you sure on this? If you can do per-sample shading (there's a cap bit for it), then you're supposed to implement set_min_samples(). The state tracker will set this accordingly if these inputs are used then. Though maybe it would make sense regardless... Roland Am 27.07.2017 um 19:54 schrieb

[Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

2017-07-27 Thread Brian Paul
Both the GLSL 4.00 specs and DX10.1 specs specify that if a fragment shader uses the sample ID or sample position inputs, the shader is automatically run at per sample frequency. Document that expectation for gallium fragment shaders. --- src/gallium/docs/source/tgsi.rst | 6 ++ 1 file change