Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Neil Roberts
Eric Engestrom writes: > That's absolutely fair :) > > I wanted to ack your patch earlier, since fixing it is good regardless, > but freedreno isn't my area so I didn't feel comfortable doing so; > I changed my mind in the mean time though, so here you go :P > Acked-by: Eric Engestrom > > You ha

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Eric Engestrom
On Wednesday, 2018-10-17 17:25:22 +0200, Neil Roberts wrote: > Eric Engestrom writes: > > > You might want to remove these instead, and use the .editorconfig [1] > > already present at src/gallium/drivers/freedreno/.editorconfig This is > > much easier to maintain than per-files settings ;) > >

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Neil Roberts
Eric Engestrom writes: > You might want to remove these instead, and use the .editorconfig [1] > already present at src/gallium/drivers/freedreno/.editorconfig This is > much easier to maintain than per-files settings ;) Either fixing it or removing it is fine by me. I now notice there is a .dir

Re: [Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Eric Engestrom
On Wednesday, 2018-10-17 15:48:41 +0200, Neil Roberts wrote: > The modeline was missing a ‘:’ after the tab-width and Emacs was > complaining every time you open a file. This patch was made with: > > sed -ri '1 s/; tab-width ([0-9])/; tab-width: \1/' \ > $(find -name \*.\[ch\] -exec grep -l --

[Mesa-dev] [PATCH] freedreno: Fix emacs modeline

2018-10-17 Thread Neil Roberts
The modeline was missing a ‘:’ after the tab-width and Emacs was complaining every time you open a file. This patch was made with: sed -ri '1 s/; tab-width ([0-9])/; tab-width: \1/' \ $(find -name \*.\[ch\] -exec grep -l -- '-\*- mode:' {} \+) --- src/gallium/drivers/freedreno/a2xx/fd2_blend.