Re: [Mesa-dev] [PATCH] egl: remove unneeded _eglGetNativePlatform check

2017-12-11 Thread Emil Velikov
On 6 December 2017 at 20:36, Ian Romanick wrote: > Do we have any tests at all that exercise this path? I don't know this > code well enough to feel comfortable reviewing this (says everyone). :( > At first I was thinking that the error "can never happen", although it seems like it can... Althoug

Re: [Mesa-dev] [PATCH] egl: remove unneeded _eglGetNativePlatform check

2017-12-06 Thread Ian Romanick
Do we have any tests at all that exercise this path? I don't know this code well enough to feel comfortable reviewing this (says everyone). :( On 11/13/2017 09:04 AM, Emil Velikov wrote: > From: Emil Velikov > > There's little point in calling _eglGetNativePlatform() in > eglCopyBuffers. The pl

Re: [Mesa-dev] [PATCH] egl: remove unneeded _eglGetNativePlatform check

2017-12-06 Thread Emil Velikov
On 13 November 2017 at 14:04, Emil Velikov wrote: > From: Emil Velikov > > There's little point in calling _eglGetNativePlatform() in > eglCopyBuffers. The platform return is identical to the one already > stored in our _EGLDisplay. > > Modulo subtle memory corruption of course. But in these case

[Mesa-dev] [PATCH] egl: remove unneeded _eglGetNativePlatform check

2017-11-13 Thread Emil Velikov
From: Emil Velikov There's little point in calling _eglGetNativePlatform() in eglCopyBuffers. The platform return is identical to the one already stored in our _EGLDisplay. Modulo subtle memory corruption of course. But in these cases returning EGL_BAD_NATIVE_PIXMAP doesn't sound right. Signed-