Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-21 Thread Varad Gautam
> On 20 April 2016 at 03:52, Rob Herring wrote: >> On Tue, Apr 19, 2016 at 8:03 PM, Emil Velikov >> wrote: >>> Looking at this patch and Varad's work >>> there a hunk missing here [1]. Did you not come across the issue in >>> question ? >> >> I don't think it is a real issue. I traced the code f

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-21 Thread Emil Velikov
On 20 April 2016 at 03:52, Rob Herring wrote: > On Tue, Apr 19, 2016 at 8:03 PM, Emil Velikov > wrote: >> Hi Rob, >> >> Please bear in mind that there's a fair bit of comments, but before >> all don't mix refactoring and new code. Please ? > > Okay. > Thanks. >> On 15 April 2016 at 17:03, Rob

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-20 Thread Rob Clark
On Tue, Apr 19, 2016 at 11:02 PM, Rob Herring wrote: >> It would ofc be good to make sure we don't break things for >> android-x86, but I think they would stick on dri2 + pre-atomic state >> w/ compile time build decisions until enough of the desktop gpu's >> support atomic.. although maybe it hel

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Rob Herring
On Tue, Apr 19, 2016 at 8:43 PM, Rob Clark wrote: > On Tue, Apr 19, 2016 at 9:03 PM, Emil Velikov > wrote: >> Hi Rob, >> >> Please bear in mind that there's a fair bit of comments, but before >> all don't mix refactoring and new code. Please ? >> >> On 15 April 2016 at 17:03, Rob Herring wrote

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Rob Herring
On Tue, Apr 19, 2016 at 8:03 PM, Emil Velikov wrote: > Hi Rob, > > Please bear in mind that there's a fair bit of comments, but before > all don't mix refactoring and new code. Please ? Okay. > On 15 April 2016 at 17:03, Rob Herring wrote: >> Add support for creating images from Android native

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Rob Clark
On Tue, Apr 19, 2016 at 9:03 PM, Emil Velikov wrote: > Hi Rob, > > Please bear in mind that there's a fair bit of comments, but before > all don't mix refactoring and new code. Please ? > > On 15 April 2016 at 17:03, Rob Herring wrote: >> Add support for creating images from Android native buffe

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Emil Velikov
Hi Rob, Please bear in mind that there's a fair bit of comments, but before all don't mix refactoring and new code. Please ? On 15 April 2016 at 17:03, Rob Herring wrote: > Add support for creating images from Android native buffers with dma-buf > fd. As dma-buf support also requires DRI image

[Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-15 Thread Rob Herring
Add support for creating images from Android native buffers with dma-buf fd. As dma-buf support also requires DRI image loader extension, add that as well. This is based on several originally patches written by Varad Gautam. I've collapsed them down to one and done a bit of reformatting. dma-bufs