Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-06-03 Thread Marek Olšák
I've reverted this commit, because it breaks Glamor with current and older X servers. Marek On Tue, May 31, 2016 at 6:32 PM, Plamena Manolova wrote: > According to the EGL specifications before binding an API > we must check whether it's supported first. If not eglBindAPI > should return EGL_FAL

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-31 Thread Plamena Manolova
According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova Reviewed-by: Brian Paul --- src/egl/main/eglapi.c | 65

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-26 Thread Brian Paul
On 05/24/2016 04:42 PM, Plamena Manolova wrote: According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-24 Thread Plamena Manolova
According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c | 65 +

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Manolova, Plamena
Hi Brian, On Mon, May 23, 2016 at 9:51 PM, Brian Paul wrote: > Hi Plamena, > > Some style nitpicks below. Feel free to take 'em or leave 'em. > I'm not too involved in EGL. > > > > On 05/23/2016 10:27 AM, Plamena Manolova wrote: > >> According to the EGL specifications before binding an API >>

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Brian Paul
Hi Plamena, Some style nitpicks below. Feel free to take 'em or leave 'em. I'm not too involved in EGL. On 05/23/2016 10:27 AM, Plamena Manolova wrote: According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FAL

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Plamena Manolova
According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c | 70 +

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Brian Paul
On 05/23/2016 09:22 AM, Plamena Manolova wrote: According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Plamena Manolova
According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c | 70 +

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-13 Thread Manolova, Plamena
Hi Daniel, Thanks for reviewing! On Fri, May 13, 2016 at 5:09 PM, Daniel Stone wrote: > Hi, > > On 13 May 2016 at 17:03, Plamena Manolova > wrote: > > @@ -444,6 +444,8 @@ _eglCreateAPIsString(_EGLDisplay *dpy) > >strcat(dpy->ClientAPIsString, "OpenVG "); > > > > assert(strlen(dpy->C

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-13 Thread Daniel Stone
Hi, On 13 May 2016 at 17:03, Plamena Manolova wrote: > @@ -444,6 +444,8 @@ _eglCreateAPIsString(_EGLDisplay *dpy) >strcat(dpy->ClientAPIsString, "OpenVG "); > > assert(strlen(dpy->ClientAPIsString) < sizeof(dpy->ClientAPIsString)); > + > + _eglGlobal.ClientAPIsString = dpy->ClientAP

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-13 Thread Plamena Manolova
According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c | 2 ++ src/egl/main/eglcurrent.h | 22 ++