Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-21 Thread Emil Velikov
On Wednesday, 18 May 2016, Erik Faye-Lund wrote: > On Wed, May 18, 2016 at 1:01 PM, Emil Velikov > wrote: > > On 18 May 2016 at 09:27, Erik Faye-Lund > wrote: > >> On Wed, May 18, 2016 at 10:12 AM, Daniel Stone > wrote: > >>> Hi, > >>> > >>> On 18 May 2016 at 00:00, Ian Romanick > wrote: > >>

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-20 Thread Matt Turner
On Thu, May 12, 2016 at 10:21 AM, Plamena Manolova wrote: > According to the EGL specifications eglQueryString(EGL_CLIENT_APIS) > should return a string containing a combination of "OpenGL", "OpenGL_ES" > and "OpenVG", any other values would be considered invalid. Due to this > when the API string

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-20 Thread Manolova, Plamena
I just thought that it might be useful to note that due to the ES2/ES3 strings being present in the APIs string some dEQP tests are currently failing. Namely dEQP-EGL.functional.negative_api* and dEQP-EGL.functional.query_context.simple.query_api On Wed, May 18, 2016 at 12:03 PM, Erik Faye-Lund w

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-18 Thread Erik Faye-Lund
On Wed, May 18, 2016 at 1:01 PM, Emil Velikov wrote: > On 18 May 2016 at 09:27, Erik Faye-Lund wrote: >> On Wed, May 18, 2016 at 10:12 AM, Daniel Stone wrote: >>> Hi, >>> >>> On 18 May 2016 at 00:00, Ian Romanick wrote: On 05/17/2016 09:59 AM, Ben Widawsky wrote: > I think you misstate

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-18 Thread Emil Velikov
On 18 May 2016 at 09:27, Erik Faye-Lund wrote: > On Wed, May 18, 2016 at 10:12 AM, Daniel Stone wrote: >> Hi, >> >> On 18 May 2016 at 00:00, Ian Romanick wrote: >>> On 05/17/2016 09:59 AM, Ben Widawsky wrote: I think you misstated this. It's not invalid to have any other value. It's in

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-18 Thread Erik Faye-Lund
On Wed, May 18, 2016 at 10:12 AM, Daniel Stone wrote: > Hi, > > On 18 May 2016 at 00:00, Ian Romanick wrote: >> On 05/17/2016 09:59 AM, Ben Widawsky wrote: >>> I think you misstated this. It's not invalid to have any other value. It's >>> invalid to not have one of the 3 values, which I suppose i

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-18 Thread Daniel Stone
Hi, On 18 May 2016 at 00:00, Ian Romanick wrote: > On 05/17/2016 09:59 AM, Ben Widawsky wrote: >> I think you misstated this. It's not invalid to have any other value. It's >> invalid to not have one of the 3 values, which I suppose is technically >> possible >> if you say support ES2, but not E

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-17 Thread Ian Romanick
On 05/17/2016 09:59 AM, Ben Widawsky wrote: > On Thu, May 12, 2016 at 06:21:38PM +0100, Plamena Manolova wrote: >> According to the EGL specifications eglQueryString(EGL_CLIENT_APIS) >> should return a string containing a combination of "OpenGL", "OpenGL_ES" >> and "OpenVG", any other values would

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-17 Thread Matt Turner
On Tue, May 17, 2016 at 9:59 AM, Ben Widawsky wrote: > On Thu, May 12, 2016 at 06:21:38PM +0100, Plamena Manolova wrote: >> According to the EGL specifications eglQueryString(EGL_CLIENT_APIS) >> should return a string containing a combination of "OpenGL", "OpenGL_ES" >> and "OpenVG", any other val

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-17 Thread Ben Widawsky
On Thu, May 12, 2016 at 06:21:38PM +0100, Plamena Manolova wrote: > According to the EGL specifications eglQueryString(EGL_CLIENT_APIS) > should return a string containing a combination of "OpenGL", "OpenGL_ES" > and "OpenVG", any other values would be considered invalid. Due to this > when the API

[Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-12 Thread Plamena Manolova
According to the EGL specifications eglQueryString(EGL_CLIENT_APIS) should return a string containing a combination of "OpenGL", "OpenGL_ES" and "OpenVG", any other values would be considered invalid. Due to this when the API string is constructed, the version of GLES should be disregarded and "Ope