Re: [Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

2017-07-19 Thread Nick Sarnie
Hi all, On Wed, Jul 19, 2017 at 4:57 AM, Daniel Stone wrote: > Adding linux-dmabuf Wayland protocol files as generated did the right > thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into > a build directory which didn't yet exist. > > Unfortunately MKDIR_GEN needs to be define

Re: [Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

2017-07-19 Thread Daniel Stone
Hi, On 19 July 2017 at 13:00, Emil Velikov wrote: > This is way off. One can AC_SUBST() it in configure.ac - simply nobody > bothered. > Can you please reword or drop this hunk? I didn't realise this; I just saw that it was separately defined in nine separate Makefiles, so assumed that was the

Re: [Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

2017-07-19 Thread Emil Velikov
On 19 July 2017 at 09:57, Daniel Stone wrote: > Adding linux-dmabuf Wayland protocol files as generated did the right > thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into > a build directory which didn't yet exist. > > Unfortunately MKDIR_GEN needs to be defined in every Makef

Re: [Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

2017-07-19 Thread Eric Engestrom
On Wednesday, 2017-07-19 09:57:34 +0100, Daniel Stone wrote: > Adding linux-dmabuf Wayland protocol files as generated did the right > thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into > a build directory which didn't yet exist. > > Unfortunately MKDIR_GEN needs to be defined

[Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

2017-07-19 Thread Daniel Stone
Adding linux-dmabuf Wayland protocol files as generated did the right thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into a build directory which didn't yet exist. Unfortunately MKDIR_GEN needs to be defined in every Makefile it's used in, and src/egl/ didn't actually have it.