Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-24 Thread Juan A. Suarez Romero
On Wed, 2018-08-08 at 17:49 +0100, Daniel Stone wrote: > Hi Juan, > > On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero > wrote: > > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > > wrote: > > > > If color buffer is locked,

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-24 Thread Juan A. Suarez Romero
On Wed, 2018-08-08 at 17:49 +0100, Daniel Stone wrote: > Hi Juan, > > On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero > wrote: > > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > > wrote: > > > > If color buffer is locked,

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
Hi Juan, On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL; > > > otherwise it can not be fre

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Juan A. Suarez Romero
On Wed, 2018-08-08 at 18:39 +0200, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > Hi Juan, > > > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL; > > > otherwise it c

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Juan A. Suarez Romero
On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > Hi Juan, > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > wrote: > > If color buffer is locked, do not set its wayland buffer to NULL; > > otherwise it can not be freed later. > > It can: see the 'if (i == ARRAY_SIZE(...))' branch

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
Hi Juan, On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero wrote: > If color buffer is locked, do not set its wayland buffer to NULL; > otherwise it can not be freed later. It can: see the 'if (i == ARRAY_SIZE(...))' branch inside wl_buffer_release. > This also fixes dEQP-EGL.functional.swap_b

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-07 Thread Juan A. Suarez Romero
On Thu, 2018-08-02 at 11:01 +0200, Juan A. Suarez Romero wrote: > If color buffer is locked, do not set its wayland buffer to NULL; > otherwise it can not be freed later. > > This also fixes dEQP-EGL.functional.swap_buffers_with_damage.* tests. CC: Daniel Stone CC: Eric Engestrom > --- > src/

[Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-02 Thread Juan A. Suarez Romero
If color buffer is locked, do not set its wayland buffer to NULL; otherwise it can not be freed later. This also fixes dEQP-EGL.functional.swap_buffers_with_damage.* tests. --- src/egl/drivers/dri2/platform_wayland.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/e