Re: [Mesa-dev] [PATCH] egl/gbm: Fix config validation

2019-10-02 Thread Robin Murphy
[ + some CCs that I probably should have figured out first time around... ] On 23/09/2019 16:40, Adam Jackson wrote: On Sat, 2019-09-21 at 18:07 +0100, Robin Murphy wrote: In converting to shift/size-based validation, we lost a condition from the ARGB/XRGB equivalence check, which left it worki

Re: [Mesa-dev] [PATCH] egl/gbm: Fix config validation

2019-10-01 Thread Eric Engestrom
On Tuesday, 2019-10-01 14:01:09 +0100, Robin Murphy wrote: > [ + some CCs that I probably should have figured out first time around... ] > > On 23/09/2019 16:40, Adam Jackson wrote: > > On Sat, 2019-09-21 at 18:07 +0100, Robin Murphy wrote: > > > In converting to shift/size-based validation, we lo

Re: [Mesa-dev] [PATCH] egl/gbm: Fix config validation

2019-09-23 Thread Adam Jackson
On Sat, 2019-09-21 at 18:07 +0100, Robin Murphy wrote: > In converting to shift/size-based validation, we lost a condition from > the ARGB/XRGB equivalence check, which left it working one way round > but not the other, and broke applications like glmark2-es2-drm on some > platforms. Restore the eq

[Mesa-dev] [PATCH] egl/gbm: Fix config validation

2019-09-23 Thread Robin Murphy
In converting to shift/size-based validation, we lost a condition from the ARGB/XRGB equivalence check, which left it working one way round but not the other, and broke applications like glmark2-es2-drm on some platforms. Restore the equivalent check that *both* configs actually have an alpha chann