Re: [Mesa-dev] [PATCH] egl/drm: ensure the backing gbm is set before using it

2019-07-31 Thread Emil Velikov
On Fri, 5 Jul 2019 at 22:58, Eric Engestrom wrote: > > On Friday, 2019-07-05 11:21:41 +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Currently, if we error out before gbm_dri is set (say due to a different > > name of the backing GBM implementation, or otherwise) the tear down will > >

Re: [Mesa-dev] [PATCH] egl/drm: ensure the backing gbm is set before using it

2019-07-05 Thread Eric Engestrom
On Friday, 2019-07-05 11:21:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently, if we error out before gbm_dri is set (say due to a different > name of the backing GBM implementation, or otherwise) the tear down will > trigger a NULL ptr deref and crash out. > > Move the gbm_dri in

[Mesa-dev] [PATCH] egl/drm: ensure the backing gbm is set before using it

2019-07-05 Thread Emil Velikov
From: Emil Velikov Currently, if we error out before gbm_dri is set (say due to a different name of the backing GBM implementation, or otherwise) the tear down will trigger a NULL ptr deref and crash out. Move the gbm_dri initialization as early as possible. To be on the extra safe side add a NU